Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mem): correctly allocate colored pages #202

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

nkosmatov
Copy link
Contributor

@nkosmatov nkosmatov commented Jan 2, 2025

fix(mem): correctly allocate colored pages
Fixes Issue #199

@josecm josecm self-assigned this Jan 2, 2025
@josecm
Copy link
Member

josecm commented Jan 2, 2025

@nkosmatov thanks for sending this fix!

The fixes themselves look great. Just a couple of nits regarding the PR itself that I'd ask to change:

  • For commit messages we follow the conventional commit scheme. So I'd ask that you replace the messaage with somehting like: fix(mem): correctly allocate colored pages
  • We have a coding style enforced by clang-format. You can apply it to your modifications simply by running make format.

@nkosmatov
Copy link
Contributor Author

nkosmatov commented Jan 6, 2025

Thank you for considering my commit. I am not a Bao developer and I am not used to the conventions. I created the commit from the website github.com and do not see how I can take into account your requests from the current commit. Should I create a new commit with another title? But I do not think that make format can be run from the website? I can try to do if you send me step-by-step instructions. Or maybe a more experienced Bao developer will be able to do the necessary PR properly and it will be faster, as the corrections are very limited.

Edited: I managed to change the message. But I do not see for the make format part.

@nkosmatov nkosmatov changed the title Possibly incorrect allocation in function pp_alloc_clr - update mem.c fix(mem): correctly allocate colored pages Jan 6, 2025
See issue bao-project#199

Signed-off-by: Nikolai Kosmatov <[email protected]>
Signed-off-by: Jose Martins <[email protected]>
@josecm josecm merged commit ee73f7e into bao-project:main Jan 6, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants