Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal qt6 support #1100

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

fibur
Copy link

@fibur fibur commented Jan 8, 2025

Changes for Qt6 adaptation.

Note: tested only on Ubuntu 22.04, with Qt 6.5.3

Qt 6 porting
I did not have time to test that with other platforms. I also didn't check all possible functionalities, as I was mainly focused on adapting for personal project, in which I only needed plain screen casting + input.

I can confirm scrcpy works, dialog is also displayed and is fully responsive. I am not sure if audio works.
image

simplescreenrecorder-2025-01-06_20.51.43.mp4

@fibur fibur force-pushed the feat/minimal-qt6-support branch from 823dc93 to bdc543d Compare January 8, 2025 13:48
@barry-ran
Copy link
Owner

need update QtScrcpyCore in this pr

@barry-ran
Copy link
Owner

Please fix the compilation error of GitHub action, even on Ubuntu, it still fails to compile

@fibur fibur force-pushed the feat/minimal-qt6-support branch 2 times, most recently from b1a6837 to 431df0f Compare January 9, 2025 17:15
@fibur fibur force-pushed the feat/minimal-qt6-support branch from 431df0f to 228b0f1 Compare January 9, 2025 17:16
@fibur
Copy link
Author

fibur commented Jan 9, 2025

need update QtScrcpyCore in this pr

I think it's done already

fibur@fibur-MS-7D93:~/QtScrcpy/QtScrcpy/QtScrcpyCore$ git log --oneline 
4ca295f (HEAD, origin/qt6) feat: Adapt to Qt6

Please fix the compilation error of GitHub action, even on Ubuntu, it still fails to compile

Fixed GitHub Actions - everything should compile now. Note that Qt6 dropped support for x86, so removed relevant MSVC x86 build from github actions. Also had to slightly modify how version is interpreted as it caused failure on MSVC

@barry-ran barry-ran merged commit a0d4056 into barry-ran:qt6 Jan 10, 2025
3 checks passed
@barry-ran
Copy link
Owner

Thank you very much for your contribution. The code style is also very rigorous

@barry-ran
Copy link
Owner

Can you help improve the Linux packaging script? Building a program that can be directly executed similar to Windows and Mac, I am not familiar with Linux packaging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants