Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ordering to put domain rules below user rules #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TetraAsh
Copy link
Contributor

This resolves issues where spam rule appear with domain rule above the user rule and thus only the domain rule gets obeyed in some circumstances

@akissa
Copy link
Collaborator

akissa commented Nov 24, 2014

This is the incorrect approach, the ordering happens in the msrulesets view

@TetraAsh
Copy link
Contributor Author

Didn't seem to work (see log below), but as soon as I ordered the rules its working fine.

Strangely and it may be coincidence or some other factor, it was fine in spamscore but not highspamscore

/var/log/maillog:
Nov 24 11:01:09 mx3 MailScanner[28453]: Read rule (To: *@domain2.com 9) from database for keyword highspamassassinscore
Nov 24 11:01:09 mx3 MailScanner[28453]: Read rule (To: [email protected] 6) from database for keyword highspamassassinscore
Nov 24 11:01:09 mx3 MailScanner[28453]: Read rule (To: [email protected] 6) from database for keyword highspamassassinscore
Nov 24 11:01:09 mx3 MailScanner[28453]: Read rule (To: *@domain1.com 8) from database for keyword highspamassassinscore

@akissa
Copy link
Collaborator

akissa commented Nov 24, 2014

That is by design, it is pointless to have user rules if they are going to be overridden by the domain rules.

@TetraAsh
Copy link
Contributor Author

it seems to me that once its found the first match it then it stops looking, so in the above an email for [email protected] would hit the *@ rule before it got to the admin@ rule

P.S. I just noticed when i re-wrote the domain names i used domain2.com and domain2.co.uk....they were supposed to be the same domain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants