-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dbt] add custom tests #570
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurfg
approved these changes
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mt bom
Muuuito bom! Parabéns, Pisa. |
laura-l-amaral
requested changes
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ficou excelente! Apenas 2 pontos de melhoria importantes aqui:
- deixar a proporção como um número entre 0 e 1 (tipo 0.05 ao inves de 5 para representar 5%) só pra manter o padrão com os outros testes que o dbt já oferece
- incluir opção de formato de data no teste incremental (não limitar apenas quando tiver as colunas de ano e mes), é importante incluir essa macro em tabelas como cnpj que só tem uma data
laura-l-amaral
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #545
1. Adiciona novos testes customizados
custom_relationships
: permite settar valores que podem ser ignorados manualmente ou informar uma proporção de erros tolerável.custom_unique_combinations_of_columns
: permite settar uma proporção de erros tolerável.2. Adiciona documentação dos testes customizados na Wiki
3. Adiciona documentação do config where na wiki
4. Adiciona explicação do uso da macro custom_get_where_subquery com config where na wiki para fazer testes incrementais
5. Adiciona protocolo de como lidar com id_municipio (ou outra chave) quando tem poucos casos que não estão no diretório na wiki
6. Adiciona teste custom_dicionaries