We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hey, The below pseudocode will always pass regardless of the contents of pkg_tar-generated tarball:
pkg_tar
load("@rules_pkg//pkg:tar.bzl", "pkg_tar") load("@rules_pkg//pkg:verify_archive.bzl", "verify_archive_test") pkg_tar( name = "a_tarball", srcs = [ ... ], ) verify_archive_test( name = "verify_package_contents", must_contain_regex = [ "anything_really", ], target = ":a_tarball", )
Problem is with must_contain_regex implementation. The variable match is undefined and should be matched. A simple typo, apparently not tested.
must_contain_regex
match
matched
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Hey,
The below pseudocode will always pass regardless of the contents of
pkg_tar
-generated tarball:Problem is with
must_contain_regex
implementation. The variablematch
is undefined and should bematched
. A simple typo, apparently not tested.The text was updated successfully, but these errors were encountered: