Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix check_must_contain_regex in verify_archive.bzl #910

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix check_must_contain_regex in verify_archive.bzl #910

wants to merge 2 commits into from

Conversation

krakeusz
Copy link

@krakeusz krakeusz commented Jan 8, 2025

Closes #909

@krakeusz
Copy link
Author

krakeusz commented Jan 9, 2025

Regarding red CI: it looks like main is red at the moment https://buildkite.com/bazel/rules-pkg/builds/3479#0194485c-e39b-4ec1-97f0-a296c1acb251

@krakeusz
Copy link
Author

krakeusz commented Jan 9, 2025

I couldn't add any 'negative' tests to verify that verify_archive_test(must_contain_regex=...) can fail. It looks like skylib's unittest doesn't allow running tests during the action execution phase.

But I can confirm that at my company this PR did the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgrindel cgrindel cgrindel approved these changes

@aiuto aiuto Awaiting requested review from aiuto aiuto is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

verify_archive_test's must_contain_regex always passes
2 participants
@krakeusz @cgrindel