-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using flow segment timeranges and related spec updates #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipnbbc
force-pushed
the
philipn-flow-segment-timeranges
branch
from
November 28, 2024 10:15
4c18ac9
to
8d88b77
Compare
samdbmg
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice explanation and diagrams
Define it as a difference between the exclusive end and the last sample timestamp.
Be specific about when the timerange uses an exclusive (samples have duration) or inclusive end (samples don't have a duration).
E.g. for 48kHz audio samples with an exclusive timerange end.
philipnbbc
force-pushed
the
philipn-flow-segment-timeranges
branch
from
January 2, 2025 14:14
8d88b77
to
8d9b9af
Compare
Co-authored-by: Sam Mesterton-Gibbons <[email protected]>
Co-authored-by: Sam Mesterton-Gibbons <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR adds an Application Note that describes the use of the Flow Segment
timerange
property. The PR also updates the definitions of the Flow Segmenttimerange
andlast_duration
properties.Pivotal Story (if relevant)
Story URL: https://www.pivotaltracker.com/story/show/188581560
Related PRs
Where appropriate. Indicate order to be merged.
Submitter PR Checks
(tick as appropriate)
Reviewer PR Checks
(tick as appropriate)
Info on PRs
The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.