-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UBI to OpenShift 4 (beta) #8
Open
Grant-Steinfeld
wants to merge
16
commits into
master
Choose a base branch
from
ubi_to_os4
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* root gitignore for python * adding python-starter code
* root gitignore for python * adding python-starter code * Currency Exchange coding starts * reads csv file but still hard codes the getCurrencyNameAndCode() * adding country currency code meta * basic code now works against tests * tests for csv reading now pass * urllib now works * test works against live api, mock data fixture monkeypatch not yet resolved * api call works tests pass * main is now flask api entrypoint * flask-restplus now works as expected
in order for `flask-restplus` requires this as to work properly with `Werkzeug` pinned to earlier version ~= 0.16.0
* hard coded value * get all currency rates
* Swagger updated to all endpoints
…on into development
* trying alpine docker first * alpine base image works now * readme formatting * essentials only * added instructions for UBI * image to get docker hub user credentials * new image for red-green-refactor * cleaned up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation of UBI to OpenShift 4 (beta) experience
@MaxShapiro32 let's review and troubleshoot - all worked except the developer web console perspective to create an app using the container image, Event Log errors in README - invalid image name