Handle bytes more directly #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we're using a Protobuf API, pull the HTTP body as bytes rather than a string. This works around weird behavior in ord. Depends on tidbyt/pixlet#1095.
benesch
commented
Nov 27, 2024
| @@ -178,6 +177,6 @@ def proto_decode_len(reader): | |||
| return out, reader | |||
|
|
|||
| def proto_next_byte(reader): | |||
| out = reader.elem_ords()[0] | |||
There was a problem hiding this comment.
For some reason, elem_ords() actually returns the bytes values, while ord(reader[0]) when reader is a string returns 65533 for non-ASCII bytes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're using a Protobuf API, pull the HTTP body as bytes rather than a string. This works around weird behavior in ord.
Depends on tidbyt/pixlet#1095.