Display total balance if recv_only is enabled #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthecarman
requested changes
Nov 25, 2024
src/main.rs
Outdated
Comment on lines
526
to
527
| let channel_balance_request = ChannelBalanceRequest {}; | ||
| let channel_balance_response = lnd.channel_balance(channel_balance_request).await?.into_inner(); |
There was a problem hiding this comment.
Suggested change
| let channel_balance_request = ChannelBalanceRequest {}; | |
| let channel_balance_response = lnd.channel_balance(channel_balance_request).await?.into_inner(); | |
| let channel_balance_response = lnd.channel_balance(ChannelBalanceRequest {}).await?.into_inner(); |
There was a problem hiding this comment.
Fixed. Thanks
alfonsoromanz
force-pushed
the
total_balance_when_recv_only
branch
from
0f2bc96 to
51d1b2a
Compare
|
Addressed feedback in 51d1b2a. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey. Thanks for putting this tool together.
I want to use the tool to query my LND balance from another application. I noticed that the balance returned is based on a daily spending limit rather than the actual balance of the node. I propose a change to display the real node balance when the tool is set up in
recv_onlymode. This would provide a more accurate representation of the node's balance in scenarios where receiving is the primary function.Also, it might not make much sense to display the default daily spending limit as the balance if it's set to receive only. What do you think?