Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover automatic block number calculation #5

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Recover automatic block number calculation #5

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bfc28c7
Define {MAX_,}RESERVED_BLOCKS as floats
May 13, 2019
5b93731
Recover automatic block number calculation
May 13, 2019
d6e659d
Correct message for minimum block count
May 13, 2019
1b2a30e
Correct also commented code to take into account reserved blocks
May 13, 2019
944a4fd
Indirect blocks must be taken into account for stats
xOneca Jun 23, 2019
3e2fce1
Restore (MAX_)RESERVED_BLOCKS to integer division
xOneca Jul 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions genext2fs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,8 +166,8 @@ static int blocksize = 1024;
#define BLOCKS_PER_GROUP 8192
#define INODES_PER_GROUP 8192
/* Percentage of blocks that are reserved.*/
#define RESERVED_BLOCKS 5/100
#define MAX_RESERVED_BLOCKS 25/100
#define RESERVED_BLOCKS (5/100.)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not fan of introducing floats just for this.
Could you please instead use something like

#define TO_RESERVED_BLOCKS(n) ((n) * 5 / 100)

?

#define MAX_RESERVED_BLOCKS (25/100.)

/* The default value for s_creator_os. */
#if defined(__linux__) && defined(EXT2_OS_LINUX)
Expand Down