-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add delay to fix race condition preventing panes from spawning. #3
Conversation
I find a better way 😅 diff --git a/bin/hyperinator b/bin/hyperinator
index 29c0aef..ce06d12 100755
--- a/bin/hyperinator
+++ b/bin/hyperinator
@@ -63,7 +63,9 @@ function start() {
console.error(err)
return
}
- console.log(`[hyperinator config: ${cfgPath}]`)
+ setTimeout(() => {
+ console.log(`[hyperinator config: ${cfgPath}]`)
+ }, 100)
break
default:
console.error('Unknown command!')
diff --git a/package.json b/package.json
index cb58813..345db0e 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
{
"name": "hyperinator",
- "version": "0.4.1",
+ "version": "0.4.2",
"description": "A layout automation plugin for Hyper.app",
"repository": "bet4it/hyperinator",
"author": "Bet4 <[email protected]>",
|
Seems to work fine! Closing this one. |
@bet4it |
Could you confirm that all the problems you faced have been fixed in the latest release? |
@bet4it No. git diff is still broken. When scrolling a multi-line diff, you cannot exit out of it by pressing |
Can't reproduce, again😅 |
No, it’s an issue with any git repo. I wasn’t doing a diff in hyperinator but something for work. The git diff command is completely broken in Hyper with this patch. Still works fine in a regular git bash shell. |
diff --git a/bin/hyperinator b/bin/hyperinator
index 29c0aef..ce06d12 100755
--- a/bin/hyperinator
+++ b/bin/hyperinator
@@ -63,7 +63,9 @@ function start() {
console.error(err)
return
}
- console.log(`[hyperinator config: ${cfgPath}]`)
+ setTimeout(() => {
+ console.log(`[hyperinator config: ${cfgPath}]`)
+ }, 100)
break
default:
console.error('Unknown command!') Do you mean this patch introduce the bug? That's impossible! This patch doesn't change anything if you don't use |
Is this a bug of other plugins? You may add other plugins back recently. |
I’m not sure if it was specifically that patch or another we tried. I did add hyperpane back because I liked having the label in the top left corner of the pane that showed the keyboard shortcut to use to swap to that active pane. |
Yeah, hyper-pane is very useful and I also use it. I don't think it's the culprit. |
Per #2 (comment).