Mise à jour des dépendances de Mongo #4740
Open
+650
−339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jenovateurs
commented
Nov 19, 2024
jenovateurs
commented
- Mongodb : https://github.com/mongodb/node-mongodb-native/releases
- Mongoose : https://github.com/Automattic/mongoose/blob/8.8.2/CHANGELOG.md
|
Le dernier check non-valide correspond à CodeQL (système d'IA de review) qui suggère d'ajouter un rate limit de partout. |
|
Oui, c'est ok, tu peux les retirer sur Github en cochant la case pour dire que c'est des faux positifs |
Shamzic
reviewed
Jan 13, 2025
| } | ||
|
|
||
| function attachAccessCookie(req: Request, res, next?) { | ||
| const cookiesParameters = { | ||
| maxAge: 7 * 24 * 3600 * 1000, | ||
| maxAge: 604800000, |
There was a problem hiding this comment.
j'aurais ajouté un commentaire sur cette constante ou nommé de manière explicite dans une constante globale
Shamzic
reviewed
Jan 13, 2025
Comment on lines
+13
to
+21
| const SurveyModel = mongoose.model<Survey>("Survey", SurveySchema) | ||
| FollowupSchema.method( | ||
| "addSurveyIfMissing", | ||
| async function (surveyType: SurveyType): Promise<Survey> { | ||
| let survey = this.surveys.find((survey) => survey.type === surveyType) | ||
| if (!survey) { | ||
| survey = await this.surveys.create({ type: surveyType }) | ||
| survey = new SurveyModel({ type: surveyType }) | ||
| this.surveys.push(survey) | ||
| await this.save() |
There was a problem hiding this comment.
Tu as testé cette partie manuellement pour vérifier que c'était iso-fonctionnel ?
Ce serait bien d'ajouter un test ici je trouve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.