Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore(deps): Bump openfisca-core[web-api] from 43.2.4 to 43.2.7 in /openfisca #4761

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 9, 2024

Bumps openfisca-core[web-api] from 43.2.4 to 43.2.7.

Changelog

Sourced from openfisca-core[web-api]'s changelog.

43.2.7 #1307

Performance

  • Fix enum's module performance issues
    • 43.0.0 fixed impending bugs in indexed_enums and improved EnumArray performance
    • However, Enun.__eq__ and Enum.encode suffered from performance degradation on large datasets
    • This changeset aims at correcting these while keeping the bugfixes provided by the aforesaid published version

Note

Some of the spectacular performances of Enum.encode came from the fact that it didn't actually work, leaving buggy behaviour unseen (see for example openfisca/openfisca-france#2357).

This PR introduces O(n) and O(1) use of fancy indexing, vector masking, and numpy.searchsorted, that scales nicely with large datasets (10k+).

However, as we need to validate data at enum encoding time, the encoding of int and str sequences can't be faster than the pre-43.0.0 just because data has to be copied over.

If ever this becomes problematic for very large datasets (50M+), we can workout a feature flag to disable fancy indexing and trusting data has been properly validated priorly by the user disabling run-time data validation, and so to gain from the performance of using a memory view instead of copying data over (that is, not using neither fancy indexing nor binary search).

However, it seems the least surprising for every user that the data be validated before encoding (out of bounds indices and wrong str values not present in an Enum).

43.2.6 #1297

Bugfix

  • Add int default to max_depth in openfisca test

43.2.5 #1296

Bugfix

  • Use new extension-template tests' path
Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [openfisca-core[web-api]](https://github.com/openfisca/openfisca-core) from 43.2.4 to 43.2.7.
- [Changelog](https://github.com/openfisca/openfisca-core/blob/master/CHANGELOG.md)
- [Commits](openfisca/openfisca-core@43.2.4...43.2.7)

---
updated-dependencies:
- dependency-name: openfisca-core[web-api]
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Dec 9, 2024
@github-actions github-actions bot added this to the BC actuel milestone Dec 9, 2024
@Shamzic Shamzic force-pushed the dependabot/pip/openfisca/openfisca-core-web-api--43.2.7 branch from 4ce294b to e743475 Compare December 10, 2024 08:30
@Shamzic
Copy link
Contributor

Shamzic commented Dec 10, 2024

RAS, je merge

@Shamzic Shamzic merged commit 35a813d into main Dec 10, 2024
29 checks passed
@Shamzic Shamzic deleted the dependabot/pip/openfisca/openfisca-core-web-api--43.2.7 branch December 10, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant