Error out on NaNs/Infinities coming from Lua. #1902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gious. Additionally NaNs are not clamped by std::clamp() leading to all sorts of access violations. In shorts NaNs should never be accepted from Lua.
github-actions bot
pushed a commit
that referenced
this pull request
Jan 18, 2025
First, NaNs and Infs are contagious, making the game object completely unusable. Additionally, NaNs are not filtered out by std::clamp()/std::min()/std::max() checks leading to all sorts of access violations, if the result is used to query engine array maps. In short NaNs are evil and should never be accepted from Lua. (#1902)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NaNs and Infs are contagious.
Additionally NaNs are not clamped by std::clamp() leading to all sorts of access violations.
In short NaNs should never be accepted from Lua.