-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sync draft quote between tabs #195
Open
bc-marco
wants to merge
5
commits into
main
Choose a base branch
from
fix/B2B-1926
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+194
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-marco
requested review from
icatalina,
LeoChowChina and
a team
as code owners
December 18, 2024 19:34
bc-marco
changed the title
fix: add util to sync data between tabs
fix: sync draft quote between tabs
Dec 18, 2024
icatalina
reviewed
Dec 19, 2024
bc-micah
requested changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good idea - I think we should add some unit test for this.
BrianJiang2021
force-pushed
the
fix/B2B-1926
branch
from
January 9, 2025 07:27
a9cde32
to
630a0b5
Compare
BrianJiang2021
force-pushed
the
fix/B2B-1926
branch
from
January 10, 2025 00:58
630a0b5
to
9bf69a1
Compare
BrianJiang2021
temporarily deployed
to
staging
January 10, 2025 01:20 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: B2B-1926
What/Why?
Add util to sync updates in slices from other tabs
Rollout/Rollback
Revert
Testing
Before
Screen.Recording.2024-12-18.at.1.32.29.p.m.mov
After
Screen.Recording.2024-12-18.at.1.30.41.p.m.mov
unit tests