Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sync draft quote between tabs #195

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: sync draft quote between tabs #195

wants to merge 5 commits into from

Conversation

bc-marco
Copy link
Contributor

@bc-marco bc-marco commented Dec 18, 2024

Jira: B2B-1926

What/Why?

Add util to sync updates in slices from other tabs

Rollout/Rollback

Revert

Testing

Before

Screen.Recording.2024-12-18.at.1.32.29.p.m.mov

After

Screen.Recording.2024-12-18.at.1.30.41.p.m.mov

unit tests
image

@bc-marco bc-marco self-assigned this Dec 18, 2024
@bc-marco bc-marco requested review from icatalina, LeoChowChina and a team as code owners December 18, 2024 19:34
@bc-marco bc-marco changed the title fix: add util to sync data between tabs fix: sync draft quote between tabs Dec 18, 2024
apps/storefront/src/store/index.ts Outdated Show resolved Hide resolved
apps/storefront/src/store/cross-tab-sync.ts Outdated Show resolved Hide resolved
apps/storefront/src/store/cross-tab-sync.ts Outdated Show resolved Hide resolved
apps/storefront/src/store/cross-tab-sync.ts Outdated Show resolved Hide resolved
apps/storefront/src/store/cross-tab-sync.ts Outdated Show resolved Hide resolved
apps/storefront/src/store/index.ts Show resolved Hide resolved
Copy link
Contributor

@bc-micah bc-micah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good idea - I think we should add some unit test for this.

.cspell.json Show resolved Hide resolved
apps/storefront/src/store/cross-tab-sync.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants