fix: headless.ts importNode to setAttribute & innerhtml #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-micah
requested review from
icatalina,
LeoChowChina and
a team
as code owners
bc-micah
force-pushed
the
fix/headless-import-node
branch
from
a42fdcb to
257cd11
Compare
bc-micah
changed the title
bc-micah
force-pushed
the
fix/headless-import-node
branch
from
fc93b80 to
2cb77f2
Compare
bc-micah
force-pushed
the
fix/headless-import-node
branch
from
615683e to
1e4d342
Compare
bc-victor
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: JIRA_TOKEN
What/Why?
importNodelooked like it works, but the browser does not actually fetch the scripts or run the js.Rollout/Rollback
We need to investigate this logic more to understand (this is already a revert)
Testing
Locally & planning to do in tier 1