Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get allowed routes on headless controller #204

Merged
merged 4 commits into from
Jan 9, 2025
Merged

Conversation

bc-victor
Copy link
Contributor

@bc-victor bc-victor commented Jan 9, 2025

Jira: B2B-1933

What/Why?

Moving getAllowedRoutes function and the route list to a separate file to avoid circular dependencies within the HeadlessController.

Rollout/Rollback

revert

Testing

Tested visibility on Catalyst
Screenshot 2025-01-09 at 3 48 54 p m

@bc-victor bc-victor requested review from icatalina, LeoChowChina and a team as code owners January 9, 2025 19:42
bc-micah and others added 2 commits January 9, 2025 13:44
* fix: refactor out the component from getAllowedRoutes

* fix: also export isMenuItem for catalyst

* fix: the file location of B3MainHeader

* fix: react types
Copy link
Contributor

@bc-micah bc-micah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - testing in staging

Copy link
Contributor

@bc-micah bc-micah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - testing in staging

Copy link
Contributor

@bc-micah bc-micah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested log in and log out on staging - works properly.

@bc-micah bc-micah merged commit 4b8ab61 into main Jan 9, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants