Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FactorModel class #98

Merged
merged 11 commits into from
Aug 10, 2023
Merged

Conversation

timtreis
Copy link
Collaborator

@timtreis timtreis commented Aug 7, 2023

TODO(@timtreis)

  • set_data_options(scale_views = False, scale_groups = False, center_groups = True)
  • set_model_options(likelihoods, factor_priors, weight_priors, groups)
  • .fit(epochs, verbose=1) 0 = nothing
  • rename _factormodels -> factormodels
  • combine two utils files

Maybe future:

  • custom callbacks
  • pass known covariates (like age so that we can regress out to get age-free results)

@timtreis timtreis linked an issue Aug 7, 2023 that may be closed by this pull request
cellij/core/_factormodel.py Outdated Show resolved Hide resolved
cellij/core/_factormodel.py Outdated Show resolved Hide resolved
cellij/core/_factormodel.py Outdated Show resolved Hide resolved
cellij/core/_factormodel.py Show resolved Hide resolved
cellij/core/_factormodel.py Show resolved Hide resolved
cellij/core/_factormodel.py Outdated Show resolved Hide resolved
cellij/core/_pyro_models.py Outdated Show resolved Hide resolved
@martinrohbeck
Copy link
Collaborator

I like the treatment of the config options 👍

@timtreis timtreis merged commit ff2c451 into main Aug 10, 2023
@timtreis timtreis deleted the feature/issue-90/refactor-base-factormodel branch August 10, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor base FactorModel Implement MOFA+
3 participants