Check metadata for each view individually #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure that the metadata is checked for each view individually. If this is not the case, then a view without metadata is assumed to have metadat as long as the first view has some. Assuming non-existing metadata leads to a concatenation of empty series, which breaks the code.
Here is a small example to reproduce the bug: Computing HVG on the mrna view leads to the issue, because this operation creates the metadata for the mrna view.
Note that
use_var
also does not work in this case (due to the added view-prefix), but I'll provide a fix in another PR..copy()
of the rna data frame does not help