Add link to trading rules wiki article in Tac Window #7349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trading rules, as explained on https://bisq.wiki/Trading_rules have a tidier layout, and allow for future adjustments in case they are needed, so it is useful to have them linked from the Tac.
I originally intended to make the word "rules" in bullet 6 into a link, but when I understood how the overlay contents are built, I rapidly changed my mind, so I thought about adding another sub-bullet above the dispute resolution link, by creating another HBox and have the two HBox's placed into a VBox, but that in turn proved unfeasible as the relative height of the hyperlinks to the preceding text were inconsistent no matter what I did.
So I finally settled for placing the two in the same HBox, and at the same time fixed the line-spacing with the above bullets, that was larger than the rest in the original version. I found no way of fixing the vertical alignment of the hyperlinks with the text, which was below the base level even in the original version.
Original:
My PR:
