Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restv2 adding pulse resource support #98

Merged
merged 5 commits into from
Dec 23, 2020
Merged

restv2 adding pulse resource support #98

merged 5 commits into from
Dec 23, 2020

Conversation

Daniel1984
Copy link
Contributor

Description:

adding support for pulse resource

Breaking changes:

none

New features:

  • rest/v2 get_pulse_profile
  • rest/v2 get_public_pulse_history
  • rest/v2 submit_pulse
  • rest/v2 delete_pulse
  • rest/v2 get_private_pulse_history
  • rest/v2 submit_pulse_comment

Fixes:

none

PR status:

  • Version bumped
  • Change-log updated
  • Documentation updated

@robertkowalski robertkowalski mentioned this pull request Dec 23, 2020
Open
robertkowalski
robertkowalski suggested changes Dec 23, 2020
View reviewed changes
Copy link

@robertkowalski robertkowalski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,

  1. opened a new issue for the nonce problem introduced by the nodejs lib
  2. missing newline at end of file needs fix, then ready for merge

robertkowalski
robertkowalski approved these changes Dec 23, 2020
View reviewed changes
Copy link

@robertkowalski robertkowalski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prdn prdn merged commit 5f30386 into bitfinexcom:master Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertkowalski robertkowalski robertkowalski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Daniel1984 @robertkowalski @prdn