-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show a warning if calendar or contacts storage is deactivated or missing #1243
Merged
rfc2822
merged 9 commits into
main-ose
from
1228-show-a-warning-in-the-main-screen-if-calendar-or-contacts-storage-is-deactivatedmissing
Jan 24, 2025
Merged
Show a warning if calendar or contacts storage is deactivated or missing #1243
rfc2822
merged 9 commits into
main-ose
from
1228-show-a-warning-in-the-main-screen-if-calendar-or-contacts-storage-is-deactivatedmissing
Jan 24, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunkup
force-pushed
the
1228-show-a-warning-in-the-main-screen-if-calendar-or-contacts-storage-is-deactivatedmissing
branch
2 times, most recently
from
January 16, 2025 14:38
303063a
to
7ecc5e0
Compare
ArnyminerZ
requested changes
Jan 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just this detail. I haven't been able to test though, just checked out the code.
ArnyminerZ
previously approved these changes
Jan 21, 2025
rfc2822
reviewed
Jan 22, 2025
rfc2822
reviewed
Jan 22, 2025
sunkup
force-pushed
the
1228-show-a-warning-in-the-main-screen-if-calendar-or-contacts-storage-is-deactivatedmissing
branch
from
January 23, 2025 14:14
d315b4c
to
79a066f
Compare
rfc2822
force-pushed
the
1228-show-a-warning-in-the-main-screen-if-calendar-or-contacts-storage-is-deactivatedmissing
branch
from
January 24, 2025 16:44
f04c537
to
81cc226
Compare
rfc2822
force-pushed
the
1228-show-a-warning-in-the-main-screen-if-calendar-or-contacts-storage-is-deactivatedmissing
branch
from
January 24, 2025 16:45
81cc226
to
6db4fc5
Compare
rfc2822
approved these changes
Jan 24, 2025
rfc2822
deleted the
1228-show-a-warning-in-the-main-screen-if-calendar-or-contacts-storage-is-deactivatedmissing
branch
January 24, 2025 16:52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Sometimes users (mostly on Lineage) disable system apps. We can show a warning in the accounts view and a notification on sync with link to the manual.
Notification at sync seems complex and should be a separate issue: #1253
Short description
Warning in Accounts View
packageChangedFlow
fromBroadCastReceiverFlow
to check whether contacts and calendar providers are installed and enabledFor testing these adb commands are helpful:
Checklist