Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed estimate gas limit instead by hard code #24

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

tienngovan
Copy link

@tienngovan tienngovan commented Mar 19, 2024

BREAKING CHANGES

  • The gasLimit is mandatory when calling method Call.
  • Method change for FeralfileExhibitionV2 contract.
    • create_artwork => createArtwork
    • swap_artwork_from_bitmark => swapArtworkFromBitmark
    • transfer => safeTransferFrom. Require from address params.
    • approve_for_all => setApprovalForAll. Require approve flag params.
  • Method change for FeralfileExhibitionV3 contract
    • register_artworks => createArtworks
    • mint_editions => batchMint
    • authorized_transfer => authorizedTransfer.
    • burn_editions => burnEditions
    • transfer => safeTransferFrom. Require from address params.
    • approve_for_all => setApprovalForAll. Require approve flag params.
  • Method change for FeralfileExhibitionV4 contract
    • approve_for_all => setApprovalForAll. Require approve flag params.

@tienngovan tienngovan force-pushed the fix/2081-bug-out-of-gas-because-gas-limit branch from 4228a77 to 5766fb7 Compare March 19, 2024 07:53
@jollyjoker992 jollyjoker992 changed the base branch from develop to main March 21, 2024 07:16
@tienngovan tienngovan force-pushed the fix/2081-bug-out-of-gas-because-gas-limit branch from 5766fb7 to 3c7382f Compare March 21, 2024 07:32
@jollyjoker992 jollyjoker992 force-pushed the fix/2081-bug-out-of-gas-because-gas-limit branch from f0bb97f to 1d0405e Compare March 21, 2024 10:39
@jollyjoker992 jollyjoker992 force-pushed the fix/2081-bug-out-of-gas-because-gas-limit branch from 1d0405e to 597d705 Compare March 21, 2024 10:48
@jollyjoker992 jollyjoker992 requested a review from lpopo0856 March 21, 2024 10:57
lpopo0856
lpopo0856 previously approved these changes Mar 21, 2024
@jollyjoker992 jollyjoker992 merged commit c8f8857 into main Mar 25, 2024
1 check passed
@jollyjoker992 jollyjoker992 deleted the fix/2081-bug-out-of-gas-because-gas-limit branch March 25, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants