[do not merge] Old portability collection PR, for reference #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- For initial win32 support - Change pythonInterface file extension to cpp because it is C++ - Requires external dependency pthread-win32 for Windows builds
…his actually being c++
Merged
rickardp
changed the title
|
Ok, we'll keep it here for reference. Please close it once not needed anymore. We'll approach you soon about cross-platform support. Thanks for all the good work so far. Let's work together to get this figured out. We're still a bit behind on getting on top of maintenance since we took over, so please excuse the delays. Thanks for your understanding! |
9 tasks
|
@rickardp This is still needed for reference, right? Would it also suffice as a closed PR or do you want to keep it open for visibility? |
|
Closing this as it seems dead and not needed anymore. Let me know if it needs reopening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially the same as PR #257. As the old PR was force pushed beyond repair, I'm reposting this for the purpose of referencing the diffs and possibly cherry picking useful parts into other PRs.
The PR sets up a pipeline that builds the .so files separately using a build matrix, then builds binary wheels for the Python packages. The MPS stuff here is just a stub and should not be merged.
AFAIK, the CMake files in this branch contain all the releevant patches to make the CPU code buildable/testable on Windows x64, Mac x64/arm64, Linux x64/arm64.
To summarize this PR should provide