Update to detekt 1.23.7 #3901
Merged
Update to detekt 1.23.7 #3901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No New Or Fixed Issues Found |
| @@ -37,6 +37,9 @@ data class EnvironmentUrlDataJson( | |||
| @SerialName("events") | |||
| val events: String? = null, | |||
| ) { | |||
| /** | |||
| * Companion object for [EnvironmentUrlDataJson]. | |||
| */ | |||
There was a problem hiding this comment.
Is there some rule we could use to avoid this? Documentation for companion objects doesn't seem to gain us anything.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3901 +/- ##
=======================================
Coverage 88.65% 88.65%
=======================================
Files 414 414
Lines 33945 33945
Branches 5006 5006
=======================================
Hits 30095 30095
Misses 2091 2091
Partials 1759 1759 ☔ View full report in Codecov by Sentry. |
SaintPatrck
previously approved these changes
Sep 10, 2024
david-livefront
force-pushed
the
update-detekt
branch
from
3a54e82 to
776baa3
Compare
david-livefront
force-pushed
the
update-detekt
branch
from
776baa3 to
d9e940d
Compare
SaintPatrck
approved these changes
Sep 11, 2024
brian-livefront
approved these changes
Sep 11, 2024
|
Thanks @SaintPatrck & @brian-livefront |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
N/A
📔 Objective
This PR updates the app to use the latest version of detekt (v1.23.7).
Release Notes!
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes