[PM-13789] add credential manager provider for passwords #4110
Conversation
Nailik
requested review from
brian-livefront,
david-livefront,
dseverns-livefront,
ahaisting-livefront and
a team
as code owners
|
|
|
Thank you for your contribution! We've added this to our internal Community PR board for review. |
bitwarden-bot
changed the title
Nailik
force-pushed
the
feature/add-password-credential-manager-provider
branch
from
9844952 to
5321cda
Compare
… android.credentials.TYPE_PASSWORD_CREDENTIAL
Nailik
force-pushed
the
feature/add-password-credential-manager-provider
branch
from
82730f4 to
cab85a9
Compare
Nailik
force-pushed
the
feature/add-password-credential-manager-provider
branch
from
4aa9f5a to
5a6e528
Compare
…ialProviderService in order to not show 2 locked entries in the credential api.
…nCredentialProviderService in order to not show 2 locked entries in the credential api." This reverts commit 1ec7bdd.
…BitwardenCredentialProviderService in order to not show 2 locked entries in the credential api."" This reverts commit c0190c0.
…pport request for passkeys and passwords at the same time
|
I would like a check/pre-review from the code owners before starting to work on the tests. Maybe this could be split into multiple smaller PRs as it got already a lot bigger than i thought it would be - and it's also a lot to review |
Nailik
changed the title
…ider # Conflicts: # app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt
…ider # Conflicts: # app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt
…ider # Conflicts: # app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/processor/Fido2ProviderProcessorImpl.kt # app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/vaultunlock/VaultUnlockViewModel.kt # app/src/main/java/com/x8bit/bitwarden/ui/autofill/fido2/manager/Fido2CompletionManagerImpl.kt # app/src/main/java/com/x8bit/bitwarden/ui/platform/composition/LocalManagerProvider.kt # app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavScreen.kt # app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt # app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt
…manager-provider' into feature/add-password-credential-manager-provider
|
due to a lot of changes in the types it's currently not compiling however i am not sure if i just waste my time here since i get no response or any info if this feature is planned ... |
|
Hi @Nailik Apologies for the late response. We've been busy shoring up our native releases. We are interested in consuming these changes and do appreciate you taking the time to submit them. As you stated, there has been refactoring that conflicts with the changes you submitted. There's potential for more refactoring once Google releases the next version of Credential Manager (1.5.0). I suggest holding this PR until the new CredMan library is available. As soon as time permits we will review and provide feedback. |
|
@SaintPatrck perfect thank you. |
🎟️ Tracking
#4100
📔 Objective
Currently there is only an implementation to provide or save Fido2 credentials via the CredentialManager.
The objective is to add the possibility to save and create Passwords.
Credential Manager usage: https://developer.android.com/identity/sign-in/credential-manager
Credential Provider to provide Credential Manager: https://developer.android.com/identity/sign-in/credential-provider
Example Project: https://github.com/android/identity-samples/tree/main/CredentialManager
Status
Working on:
Found issues:
showFido2ErrorDialogdoesn't always show the correct reason, however to stay consistent theshowPaswordErrorDialogalso shows always the same issue📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes