Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16827] Only report coverage when tests pass #4550

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

vvolkgang
Copy link
Member

@vvolkgang vvolkgang commented Jan 10, 2025

🎟️ Tracking

PM-16827

📔 Objective

We won't have coverage reports when tests fail.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vvolkgang vvolkgang added the ci/cd Updates to automated workflows label Jan 10, 2025
@vvolkgang vvolkgang requested a review from a team as a code owner January 10, 2025 19:15
@vvolkgang vvolkgang enabled auto-merge January 10, 2025 19:15
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details1652fbe0-aa45-40e7-9c5c-581b49d55109

No New Or Fixed Issues Found

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.31%. Comparing base (a3096c0) to head (adcb25f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4550   +/-   ##
=======================================
  Coverage   88.31%   88.31%           
=======================================
  Files         603      603           
  Lines       40272    40272           
  Branches     5697     5697           
=======================================
  Hits        35565    35565           
  Misses       2721     2721           
  Partials     1986     1986           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vvolkgang vvolkgang added this pull request to the merge queue Jan 10, 2025
Merged via the queue into main with commit 41d9e96 Jan 10, 2025
9 checks passed
@vvolkgang vvolkgang deleted the test-report-fix branch January 10, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Updates to automated workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants