Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-5760] Add autofill support for Spin Browser #2942

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

theRealPadster
Copy link
Mannequin

@theRealPadster theRealPadster mannequin commented Jan 17, 2024

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Bitwarden autofill doesn't work in Spin Browser. More details in this issue: #2848.
Spin Browser is a browser based on Firefox for mobile that adds built-in internet filtering functionality.
Website: https://spinsafebrowser.com
Google Play: https://play.google.com/store/apps/details?id=com.nationaledtech.spinbrowser

Code changes

  • AutofillHelpers.cs: Added "com.nationaledtech.spinbrowser",
  • AccessibilityHelpers.cs: Added new Browser("com.nationaledtech.spinbrowser", "mozac_browser_toolbar_url_view"),
  • autofillservice.xml Added <compatibility-package android:name="com.nationaledtech.spinbrowser" android:maxLongVersionCode="10000000000"/>
  • Some trailing whitespace was also auto-removed from AutofillHelpers.cs and AccessibilityHelpers.cs

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@CLAassistant
Copy link
Mannequin

CLAassistant mannequin commented Jan 17, 2024

CLA assistant check
All committers have signed the CLA.

@bitwarden-bot
Copy link
Mannequin

bitwarden-bot mannequin commented Jan 17, 2024

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-5760

@bitwarden-bot bitwarden-bot mannequin added the community-pr label Jan 17, 2024
@bitwarden-bot bitwarden-bot mannequin changed the title Add autofill support for Spin Browser [PM-5760] Add autofill support for Spin Browser Jan 17, 2024
@djsmith85 djsmith85 linked an issue Jan 17, 2024 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants