Addressing persistent volume permissions issue and default user creation inside the image #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the uid and gid values from the user for persistant storage creation
…oup permissions inside the entrypoint
gardner
reviewed
Jan 14, 2025
| # Change ownership of the working directory | ||
| chown -R "$USER_ID":"$GROUP_ID" "$MEDIA_PATH" | ||
|
|
||
|
|
There was a problem hiding this comment.
At this point the container is running as root. One of the reasons to drop root is for more security.
Perhaps we can su the exec on line 23?
gardner
reviewed
Jan 14, 2025
| You can mount media files from host to container and use `MEDIA_PATH` environment variable to set the media path for black candy. You can now provide the uid and gid as env arguments so that the permissions of "<your_media_data_path>" is properly aligned with media path set for black candy above. | ||
|
|
||
| ```shell | ||
| docker run -e UID=$(id -u) -e GID=$(id -g) -v <your_media_data_path>:/media_data -e MEDIA_PATH=/media_data ghcr.io/blackcandy-org/blackcandy:latest |
There was a problem hiding this comment.
Consider updating the docker compose example as well.
Line 131 in dd86df5
|
Nice work! I am not a maintainer on this project but I left a couple of comments to consider. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the docker image has a default user "app" with the uid and gid set to 1000. this is causing difficulty in mapping the persistent storage from the host with a different uid and gid. Addressed in this issue #403. Not sure what exactly is the purpose of the default user inside the image.
I removed the default user creation and now the user & group gets created as part of the entrypoint script based on the uid and gid given from the docker run command as an env variable. The changes in this PR will take care of the user permissions of the directories mounted.
I am using this updated docker images in my homelab and I have no problem in using the blackcandy to play songs till now. Hope this is helpful