Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghmc dev #585

Merged
merged 4 commits into from
Nov 10, 2023
Merged

ghmc dev #585

merged 4 commits into from
Nov 10, 2023

Conversation

williwilliams3
Copy link
Contributor

Thank you for opening a PR!

A few important guidelines and requirements before we can merge your PR:

  • If I add a new sampler, there is an issue discussing it already;
  • We should be able to understand what the PR does from its title only;
  • There is a high-level description of the changes;
  • There are links to all the relevant issues, discussions and PRs;
  • The branch is rebased on the latest main commit;
  • Commit messages follow these guidelines;
  • The code respects the current naming conventions;
  • Docstrings follow the numpy style guide
  • pre-commit is installed and configured on your machine, and you ran it before opening the PR;
  • There are tests covering the changes;
  • The doc is up-to-date;
  • If I add a new sampler* I added/updated related examples

Consider opening a Draft PR if your work is still in progress but you would like some feedback from other contributors.

Closes #584.
There is no need to add new tests since the tests of the original sampler are applicable to this small modification.

Copy link
Member

@junpenglao junpenglao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@junpenglao junpenglao merged commit df5414e into blackjax-devs:main Nov 10, 2023
5 checks passed
@williwilliams3 williwilliams3 deleted the ghmc_dev branch November 10, 2023 12:14
junpenglao pushed a commit that referenced this pull request Mar 12, 2024
* Update .gitignore

* Remove redundant steps in ghmc

* Update ghmc.py

* Update ghmc.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify ghmc
2 participants