created histogram and scatter chart with scatter point selection per bin #10
+62
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddragula
suggested changes
Apr 20, 2023
Comment on lines
45
to
48
| } else { | ||
| // if bin is already selected, unselect | ||
| bin.select(); | ||
| } |
There was a problem hiding this comment.
Since you call bin.select() twice at the beginning of two blocks (in if and in else), consider whether it would not be better to call it once, before the if statement.
There was a problem hiding this comment.
Fixes as per your comment. Also needed to change the if condition (from !bin.selected to bin.selected).
Comment on lines
33
to
36
| // if bin is NOT already selected, select bin and associated scatter points | ||
| bin.select(); | ||
| bin.setState('select'); | ||
|
|
There was a problem hiding this comment.
I think you don't need to call bin.setState('select') if you have already called bin.select().
ddragula
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.