created line chart with blue circle following cursor + save-on-click #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on-click functionality
pawellysy
suggested changes
Apr 25, 2023
Comment on lines
29
to
33
| if (cursorCircle) { | ||
| cursorCircle.attr({ x, y }); | ||
| } else { | ||
| cursorCircle = chart.renderCircle(x, y); | ||
| } |
There was a problem hiding this comment.
Here you are checking if the cursorCircle exists. Why don't you create it straight away (e.g. in the line 20) and then you are sure in the mousemove event, that it exists? No If statement in the mouse move to fire!
There was a problem hiding this comment.
Fixed! I just created it at position (0,0) and hid it.
Comment on lines
38
to
40
| if (cursorCircle) { | ||
| cursorCircle.hide(); | ||
| } |
Comment on lines
44
to
46
| if (cursorCircle) { | ||
| cursorCircle.show(); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.