Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highcharts/7 connecting column edges #8

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Highcharts/7 connecting column edges #8

wants to merge 4 commits into from

Conversation

MarkusBarstad
Copy link
Contributor

No description provided.

@MarkusBarstad MarkusBarstad self-assigned this Aug 25, 2022
@MarkusBarstad
Copy link
Contributor Author

Thank you for good feedback, mfilipiec.

I tried to change it based on your suggestions, I realized, looking back at my code now and reading your review, that I didn't need an array of bools nor my own legendItemClick-event when series already of course have a visibility-value that gets toggled by default and I could simply check this as you stated x)

mfilipiec
mfilipiec approved these changes Sep 26, 2022
View reviewed changes
Copy link

@mfilipiec mfilipiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

You did the job before the code review, these code-related suggestions are more general as clean code hints. But as you wrote, over time you will pay attention to it yourself and it will become a habit.

@MarkusBarstad
Copy link
Contributor Author

Thank you :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfilipiec mfilipiec mfilipiec approved these changes

Assignees

@MarkusBarstad MarkusBarstad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkusBarstad @mfilipiec