Merge pull request #7 from blockydevs/switch-to-adapter-architecture

switch to adapter architecture pattern

src/app.module.ts

@@ -10,6 +10,7 @@ import { CustomerModule } from './customer/customer.module';
 import { OrderModule } from './order/order.module';
 import { ProductModule } from './product/product.module';
 import { CartModule } from './cart/cart.module';
+import { StoreManagerModule } from './store-manager/store-manager.module';
 
 @Module({
   imports: [
@@ -48,6 +49,7 @@ import { CartModule } from './cart/cart.module';
     OrderModule,
     CustomerModule,
     HttpModule,
+    StoreManagerModule,
   ],
   controllers: [],
   providers: [],

src/cart/cart.module.ts

@@ -5,6 +5,7 @@ import { OrderModule } from '../order/order.module';
 import { CustomerModule } from '../customer/customer.module';
 import { ProductModule } from '../product/product.module';
 import { CartService } from './cart.service';
+import { StoreManagerModule } from '../store-manager/store-manager.module';
 
 @Module({
   imports: [
@@ -14,6 +15,7 @@ import { CartService } from './cart.service';
     CustomerModule,
     ProductModule,
     CustomerModule,
+    StoreManagerModule,
   ],
   controllers: [CartController],
   providers: [CartService],

src/cart/cart.service.ts

@@ -1,53 +1,49 @@
 import {
+  BadRequestException,
   ConflictException,
-  HttpException,
-  HttpStatus,
   Inject,
   Injectable,
   NotFoundException,
 } from '@nestjs/common';
-import { HttpService } from '@nestjs/axios';
-import { firstValueFrom } from 'rxjs';
 import { Cart } from './cart.interface';
 import { ProductService } from '../product/product.service';
 import { OrderService } from '../order/order.service';
 import { CustomerService } from '../customer/customer.service';
 import { CustomerEntity } from '../customer/entitites/customer.entity';
 import { RedisCache } from 'cache-manager-redis-yet';
 import { CACHE_MANAGER } from '@nestjs/cache-manager';
+import { StoreManagerPort } from '../store-manager/store-manager.port';
 
 @Injectable()
 export class CartService {
   constructor(
-    private readonly httpService: HttpService,
     private readonly productService: ProductService,
     private readonly orderService: OrderService,
     private readonly customerService: CustomerService,
+    @Inject(StoreManagerPort)
+    private readonly storeManagerPort: StoreManagerPort,
     @Inject(CACHE_MANAGER) private cacheManager: RedisCache,
   ) {}
 
   public async getCartData(cartId: string): Promise<Cart> {
-    console.log('STARTED INTEGRATION TEST! (BAD CLASS)');
     const cachedData = await this.cacheManager.get<Cart>(cartId);
 
     if (cachedData) {
       console.log(`Reading cart data for cartId(CACHED): ${cartId}`);
       return cachedData;
     }
 
-    const { data } = await firstValueFrom(
-      this.httpService.get(`https://fakestoreapi.com/carts/${cartId}`),
-    );
+    const cartData = await this.storeManagerPort.getCartData(cartId);
 
-    if (!data) {
+    if (!cartData) {
       throw new NotFoundException(
         `Cart with id ${cartId} not found in the external API.`,
       );
     }
 
-    await this.cacheManager.set(cartId, data as Cart);
+    await this.cacheManager.set(cartId, cartData);
 
-    return data as Cart;
+    return cartData;
   }
 
   public async finalizeCart(cartId: string) {
@@ -61,20 +57,19 @@ export class CartService {
     const cartData: Cart = await this.getCartData(cartId);
     let cartValue: number = 0;
 
+    if (cartData.products.length === 0) {
+      throw new BadRequestException(
+        `Cannot complete transaction for empty cart: ${cartId}`,
+      );
+    }
+
     for (const product of cartData.products) {
-      if (product.productId === 1000) {
-        throw new HttpException('Custom conflict message', HttpStatus.CONFLICT);
-      }
       const p = await this.productService.getProductData(product.productId);
       cartValue += p.price;
     }
 
     console.log(`Cart ${cartId} has total value of: ${cartValue}`);
 
-    if (cartValue === 0) {
-      throw new Error(`Cannot complete transaction for empty cart: ${cartId}`);
-    }
-
     const customerEntity: CustomerEntity =
       await this.customerService.getOrCreateCustomerById(
         cartData.userId.toString(),

src/config/typeorm-tests.ts

@@ -8,7 +8,7 @@ const config: DataSourceOptions = {
   port: 5432,
   username: 'postgres',
   password: 'postgres',
-  database: 'mantra_quest_tests',
+  database: 'postgres',
   entities: ['dist/**/*.entity{.ts,.js}'],
   synchronize: true,
 };

src/config/typeorm.ts

@@ -13,9 +13,9 @@ const config: DataSourceOptions = {
   schema: process.env.DATABASE_SCHEMA || 'public',
   host: process.env.DATABASE_HOST || 'localhost',
   port: parseInt(process.env.DATABASE_PORT, 10) || 5432,
-  username: process.env.DATABASE_USERNAME || 'mantra',
-  password: process.env.DATABASE_PASSWORD || 'mantra',
-  database: process.env.DATABASE_NAME || 'mantra_quest_handler',
+  username: process.env.DATABASE_USERNAME || 'admin',
+  password: process.env.DATABASE_PASSWORD || 'admin',
+  database: process.env.DATABASE_NAME || 'admin_db',
   entities: ['dist/**/*.entity{.ts,.js}'],
   migrations: ['dist/migrations/*{.ts,.js}'],
   logging: logging,

src/product/product.module.ts

@@ -1,9 +1,10 @@
 import { Module } from '@nestjs/common';
 import { ProductService } from './product.service';
 import { HttpModule } from '@nestjs/axios';
+import { StoreManagerModule } from '../store-manager/store-manager.module';
 
 @Module({
-  imports: [HttpModule],
+  imports: [HttpModule, StoreManagerModule],
   providers: [ProductService],
   exports: [ProductService],
 })

src/product/product.service.ts

@@ -1,24 +1,25 @@
-import { Injectable, NotFoundException } from '@nestjs/common';
-import { HttpService } from '@nestjs/axios';
+import { Inject, Injectable, NotFoundException } from '@nestjs/common';
 import { Product } from './product.interface';
-import { firstValueFrom } from 'rxjs';
+import { StoreManagerPort } from '../store-manager/store-manager.port';
 
 @Injectable()
 export class ProductService {
-  constructor(private readonly httpService: HttpService) {}
+  constructor(
+    @Inject(StoreManagerPort)
+    private readonly storeManagerPort: StoreManagerPort,
+  ) {}
 
   public async getProductData(productId: number): Promise<Product> {
-    const { data } = await firstValueFrom(
-      this.httpService.get(`https://fakestoreapi.com/products/${productId}`),
+    const productData = await this.storeManagerPort.getProductData(
+      productId.toString(),
     );
-
-    if (!data) {
+    if (!productData) {
       console.log(`Product ${productId} not found`);
       throw new NotFoundException(
         `Product with id ${productId} not found in the external API.`,
       );
     }
 
-    return data;
+    return productData;
   }
 }

src/store-manager/fake-api/fake-api-store-manager.adapter.ts

@@ -0,0 +1,26 @@
+import { StoreManagerPort } from '../store-manager.port';
+import { firstValueFrom } from 'rxjs';
+import { Cart } from '../../cart/cart.interface';
+import { Injectable } from '@nestjs/common';
+import { HttpService } from '@nestjs/axios';
+import { Product } from '../../product/product.interface';
+
+@Injectable()
+export class FakeApiStoreManagerAdapter implements StoreManagerPort {
+  constructor(private readonly httpService: HttpService) {}
+
+  public async getCartData(cartId: string): Promise<Cart> {
+    const { data } = await firstValueFrom(
+      this.httpService.get(`https://fakestoreapi.com/carts/${cartId}`),
+    );
+
+    return data as Cart;
+  }
+
+  public async getProductData(productId: string): Promise<Product> {
+    const { data } = await firstValueFrom(
+      this.httpService.get(`https://fakestoreapi.com/products/${productId}`),
+    );
+    return data;
+  }
+}