Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(optimism): Re-use L1BlockInfoTx from maili #1984

Closed
wants to merge 1 commit into from

Conversation

refcell
Copy link
Contributor

@refcell refcell commented Jan 9, 2025

Description

Note

This PR must be pointed to upstream bluealloy/revm and should not be merged until it points upstream.

Warning

Not ready to point upstream until revm l1 block info functionality has been upstreamed and released in a new version of the maili_protocol crate.

Kona as well as other libraries + applications use optimism types from maili. maili-protocol exposes the L1BlockInfoTx type that provides all the functionality used in revm's custom L1BlockInfo type.

This PR removes the redundant L1BlockInfo type from revm, using maili_protocol::L1BlockInfoTx instead.

@refcell refcell closed this Jan 9, 2025
Copy link

codspeed-hq bot commented Jan 9, 2025

CodSpeed Performance Report

Merging #1984 will not alter performance

Comparing op-rs:maili (5992952) with main (a2451cd)

Summary

✅ 8 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant