Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: support reading multiple audio tracks (#179) #200

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Dec 10, 2024

Fixes #179

@aler9 aler9 changed the title Feature/client multiaudio client: support reading multiple audio tracks (#179) Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 87.15596% with 14 lines in your changes missing coverage. Please review.

Project coverage is 73.13%. Comparing base (7b2e499) to head (855813d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
client_primary_downloader.go 87.50% 4 Missing and 3 partials ⚠️
client_stream_downloader.go 86.66% 4 Missing ⚠️
client_stream_processor_fmp4.go 85.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
+ Coverage   73.10%   73.13%   +0.02%     
==========================================
  Files          57       57              
  Lines        3964     3975      +11     
==========================================
+ Hits         2898     2907       +9     
- Misses        871      872       +1     
- Partials      195      196       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 force-pushed the feature/client-multiaudio branch from a5eaa57 to 855813d Compare December 10, 2024 18:56
@aler9 aler9 merged commit 047a1d4 into main Dec 10, 2024
8 checks passed
@aler9 aler9 deleted the feature/client-multiaudio branch December 10, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

client: support reading all renditions at once
1 participant