Fixed definition of xarray dimensionality during build configuration #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielballan
force-pushed
the
fix-build-config-of-xarray
branch
from
94cbd5a to
2b97e79
Compare
danielballan
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an error identified while trying to read an array inside an xarray.Dataset with a dimension size greater that 2
Description
This error was identified and tracked while trying to read some data from BlueSky runs for the Data Security project at SRX.
Motivation and Context
It was identified that the
xs_flourarray was returning an error while data was requested through the,read()method in its parent node. This means that these two examples were failing:Initially, it was thought the problem was on the client side but the error was tracked all the way to the server side and it was identified that the error was being saved with the document at the moment this one was built.
It was also identified that part of this error is generated during the definition of some area detectors in a different repo (https://github.com/NSLS-II/nslsii/blob/master/nslsii/areadetector/xspress3.py#L139-L143)
The changes in this PR solve this conflict by making the definition of the xarray dimensions more robust but it is recommended to fix the original problem in this second repo.