FIX: data padding bug in mongo_normalized #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwbischof
approved these changes
Oct 10, 2024
gwbischof
changed the title
danielballan
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had several design discussions about implicit padding and trimming. I think it probably isn't the right choice to pad and trim by default, because it can affect scientific results. This PR fixes a bug with the implicit padding and adds tests.
I think more investigation is required to figure out how to pad and trim in a better way, that is out of the scope of this PR. - @gwbischof
default_validate_shapehad some trimming logic that wasn't doing anything, the trimming was happening elsewhere in the code.default_validate_shapewas falling for multi-dimensional data.Buggy logic:
Fix: