Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and test 'chunks' escape hatch. #826

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

danielballan
Copy link
Member

Data is typically chunked using a heuristic. We support a "chunks" key, next to "shape" in the descriptor, as a way to override the heuristic. This has been in the codebase for quite awhile but evidently not ever actually run because it is broken. This fixes it and adds a unit test. The fix was also tested in the wild:

In [1]: from tiled.client import from_profile, show_logs

In [2]: c = from_profile('tes')

In [3]: c['95820398-d829-4088-a023-746a78c01f4f']['primary']['data']['fluor']

Looking forward, we agree that StreamResource will enable chunking. Putting chunks in the descriptor is just an escape hatch for legacy documents.

@genematx genematx self-requested a review October 4, 2024 21:24
@genematx genematx merged commit 47623b0 into bluesky:main Oct 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants