Fix and test 'chunks' escape hatch. #826
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data is typically chunked using a heuristic. We support a
"chunks"
key, next to"shape"
in the descriptor, as a way to override the heuristic. This has been in the codebase for quite awhile but evidently not ever actually run because it is broken. This fixes it and adds a unit test. The fix was also tested in the wild:Looking forward, we agree that StreamResource will enable chunking. Putting chunks in the descriptor is just an escape hatch for legacy documents.