-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review StreamResource and StreamDatum Schemas #301
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in #296 I'm happy with the changes to go in, and as discussed with @coretl just now, I'm happy for this to go in so long as ophyd-async is pinned to <2.0 until after our experiment in June, then I'll adjust our deployed services. The implementation looks correct, just one repeated nit to make the history of changes a little clearer.
Co-authored-by: DiamondJoseph <[email protected]>
Co-authored-by: DiamondJoseph <[email protected]>
Co-authored-by: DiamondJoseph <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some minor edits. Then I think this is good to go in.
Co-authored-by: Dan Allan <[email protected]>
Co-authored-by: Dan Allan <[email protected]>
Co-authored-by: Dan Allan <[email protected]>
Review the schemas of Stream Resource and Stream Datum documents to facilitate storage and client access.
Description
path_semantics
fromStream Resource
andStream Datum
schemas.root
andresource_path
withuri
. It may be a path on the local filesystem,file://localhost/{path}
, a path on a shared filesystemfile://{host}/{path}
, to be remapped at read time via local mount config, or a non-file-based resource likes3://...
.spec
tomimetype
and use MIME type values likeapplication/x-hdf5
. It is expected that any information about options like SWMR will be passed in theresource_kwargs
(parameters
, see below).resource_kwargs
toparameters
. The wordresource_
is a bit redundant here, and the wordkwargs
is a Python-ism.Motivation and Context
This PR is based on the discussion and agreed recommendations made in Issue #296. The main motivation is to simplify and future-proof the access to data by consumers and clients, such as Tiled.
How Has This Been Tested?
Using existing tests (with renamed/replaced variables).