Accept Python dict from client "write_dataframe" and TableAdapter #771
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ref of #733.
Both cases insist upon a dataframe-compatible shape. For
write_dataframe
:pyarrow.lib.Table.validate()
is in the stack trace, and docs say that a pyarrow Table is:For TableAdapter:
This comes from
dask.dataframe.from_dict
.Lastly, Dan pointed out that this dict support let us slightly simplify
generated_minimal.py
, and I've confirmed that a simple dict replicates the example identically.Checklist