Test against php 8.4 #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Test against php 8.4 * Update symfony/phpunit-bridge * Allow to install phpunit 10
bocharsky-bw
requested changes
Oct 10, 2024
| @@ -34,4 +34,4 @@ jobs: | |||
| dependency-versions: ${{ matrix.dependency-versions }} | |||
|
|
|||
| - name: Run PHPUnit tests | |||
| run: ./vendor/bin/simple-phpunit | |||
| run: ./vendor/bin/phpunit | |||
There was a problem hiding this comment.
I think this should be reverted. We still need to use simple-phpunit, but if we want to use a newer PHPUnit version - we can specify the exact version with SYMFONY_PHPUNIT_VERSION in phpunit.xml.dist .
| @@ -27,7 +27,8 @@ | |||
| }, | |||
| "require-dev": { | |||
| "dg/bypass-finals": "^1.3", | |||
| "symfony/phpunit-bridge": "^5.4|^6.0" | |||
| "symfony/phpunit-bridge": "^5.4|^6.0|^7.0", | |||
| "phpunit/phpunit": "^9.0|^10.0" | |||
There was a problem hiding this comment.
And so this can be reverted - that's a feature of PHPUnit bridge, it allows you to get rid of PHPUnit dependency directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test against php 8.4
Update symfony/phpunit-bridge
Allow to install phpunit 10