Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change test/Jamfile to work after bcp --namespace #81

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

pdimov
Copy link
Member

@pdimov pdimov commented May 26, 2019

I'm trying to fix bcp to work again and adding tests for it (boostorg/bcp@1025e7e), and I'm using program_options because it's the only library exercising the boost-lib rule from Jamroot, which was one of the things that were broken.

bcp --namespace=foo renames the libraries from boost_bar to foo_bar, but it doesn't touch test/Jamfile, which still wanted to link to boost_program_options. Changing it to refer to /boost//program_options instead fixes it.

The manual <define>BOOST_PROGRAM_OPTIONS_DYN_LINK=1 was unnecessary, because it was supplied by boost-lib, and it masked the fact that boost-lib was erroneously changed by bcp to define FOO_PROGRAM_OPTIONS_DYN_LINK instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant