Providing a minor change to where the from_http and to_binary methods/functions come from. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/functions come from. Without this you will see messages like the following: ``` deprecation.DeprecatedWarning: to_binary is deprecated as of 1.6.0. Use cloudevents.conversion.to_binary function instead caught to_binary is deprecated as of 1.6.0. Use cloudevents.conversion.to_binary function instead Function raised to_binary is deprecated as of 1.6.0. Use cloudevents.conversion.to_binary function instead ```
|
@sferich888 tests are failing? |
|
@matejvasek yea I'm investing why, I haven't quite figured out what is going on on. This shouldn't have broken anything but that's what I get for making assumptions. |
|
@matejvasek ok; I got it figured out; in addition to the method location change; there is also a method argument change that needs to be made. https://github.com/cloudevents/sdk-python/blob/1.7.0/cloudevents/http/http_methods.py#L54-L59 differs from: https://github.com/cloudevents/sdk-python/blob/1.7.0/cloudevents/conversion.py#L92-L97 What we are now using. |
|
/approve |
matejvasek
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this you will see messages like the following: