Skip to content
This repository has been archived by the owner on Sep 6, 2020. It is now read-only.

Compress files on add instead of using Phar::compressFiles (fixes #80) #137

Open
wants to merge 1 commit into
base: 2.0
Choose a base branch
from

Conversation

remisauvat
Copy link

Apply file compression when adding a file instead of using Phar::compressFiles at the end.
This avoid the issue of opening too many files.

On my project the build even runs faster for ~1200 files.

Tests with compressFiles:

Building...

real    0m23.524s
user    0m14.499s
sys     0m8.972s

New version with compress on the fly

Building...

real    0m19.612s
user    0m10.440s
sys     0m9.135s

@kherge kherge self-assigned this Apr 7, 2016
@lordgnu
Copy link

lordgnu commented Jan 30, 2017

Hoping this will get reviewed soon and merged into next release. Since I am restricted to using the Phar file release, I have had to disable compression in order to allow our project to build which has increased the resulting phar file size by 600%

Copy link

@lordgnu lordgnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have applied these changes and confirmed that they work as advertised. I have also confirmed that all PHP Unit tests complete successfully

@theofidry
Copy link
Member

I'm not really convinced of the results: box-project/box#29

Did I miss something?

@remisauvat
Copy link
Author

I cannot access the blackfire graphs. Can you upload a screenshot ?

@theofidry
Copy link
Member

theofidry commented Jan 22, 2018

Damn, looks like I accidentally deleted them. I'll redo them tonight

@theofidry
Copy link
Member

Profiles updated

@remisauvat
Copy link
Author

Still the link here box-project/box#29 (comment) give a 404 not found

@theofidry
Copy link
Member

Should be fixed, I forgot to make them public

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants