fix: don't add djs-dragging class to non-diagram elements

Related to bpmn-io/bpmn-js#2002
bpmn-io · Nov 3, 2023 · ec29a7e · ec29a7e
1 parent 67af6b8
commit ec29a7e
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 19 deletions.
diff --git a/lib/features/bendpoints/BendpointMovePreview.js b/lib/features/bendpoints/BendpointMovePreview.js
@@ -21,11 +21,11 @@ var RECONNECT_START = 'reconnectStart',
     RECONNECT_END = 'reconnectEnd',
     UPDATE_WAYPOINTS = 'updateWaypoints';
 
-var MARKER_OK = 'connect-ok',
-    MARKER_NOT_OK = 'connect-not-ok',
+var MARKER_CONNECT_OK = 'connect-ok',
+    MARKER_CONNECT_NOT_OK = 'connect-not-ok',
     MARKER_CONNECT_HOVER = 'connect-hover',
-    MARKER_CONNECT_UPDATING = 'djs-updating',
-    MARKER_DRAGGER = 'djs-dragging';
+    MARKER_UPDATING = 'djs-updating',
+    MARKER_DRAGGING = 'djs-dragging';
 
 var HIGH_PRIORITY = 1100;
 
@@ -61,12 +61,10 @@ export default function BendpointMovePreview(bendpointMove, injector, eventBus,
     connection.waypoints = newWaypoints;
 
     // add dragger gfx
-    var draggerGfx = context.draggerGfx = addBendpoint(canvas.getLayer('overlays'));
+    context.draggerGfx = addBendpoint(canvas.getLayer('overlays'));
 
-    svgClasses(draggerGfx).add('djs-dragging');
-
-    canvas.addMarker(connection, MARKER_DRAGGER);
-    canvas.addMarker(connection, MARKER_CONNECT_UPDATING);
+    canvas.addMarker(connection, MARKER_DRAGGING);
+    canvas.addMarker(connection, MARKER_UPDATING);
   });
 
   eventBus.on('bendpoint.move.hover', function(event) {
@@ -83,11 +81,11 @@ export default function BendpointMovePreview(bendpointMove, injector, eventBus,
       }
 
       if (allowed) {
-        canvas.removeMarker(hover, MARKER_NOT_OK);
-        canvas.addMarker(hover, MARKER_OK);
+        canvas.removeMarker(hover, MARKER_CONNECT_NOT_OK);
+        canvas.addMarker(hover, MARKER_CONNECT_OK);
       } else if (allowed === false) {
-        canvas.removeMarker(hover, MARKER_OK);
-        canvas.addMarker(hover, MARKER_NOT_OK);
+        canvas.removeMarker(hover, MARKER_CONNECT_OK);
+        canvas.addMarker(hover, MARKER_CONNECT_NOT_OK);
       }
     }
   });
@@ -102,7 +100,7 @@ export default function BendpointMovePreview(bendpointMove, injector, eventBus,
 
     if (hover) {
       canvas.removeMarker(hover, MARKER_CONNECT_HOVER);
-      canvas.removeMarker(hover, target ? MARKER_OK : MARKER_NOT_OK);
+      canvas.removeMarker(hover, target ? MARKER_CONNECT_OK : MARKER_CONNECT_NOT_OK);
     }
   });
 
@@ -194,12 +192,12 @@ export default function BendpointMovePreview(bendpointMove, injector, eventBus,
     // remove dragger gfx
     svgRemove(draggerGfx);
 
-    canvas.removeMarker(connection, MARKER_CONNECT_UPDATING);
-    canvas.removeMarker(connection, MARKER_DRAGGER);
+    canvas.removeMarker(connection, MARKER_UPDATING);
+    canvas.removeMarker(connection, MARKER_DRAGGING);
 
     if (hover) {
-      canvas.removeMarker(hover, MARKER_OK);
-      canvas.removeMarker(hover, target ? MARKER_OK : MARKER_NOT_OK);
+      canvas.removeMarker(hover, MARKER_CONNECT_OK);
+      canvas.removeMarker(hover, target ? MARKER_CONNECT_OK : MARKER_CONNECT_NOT_OK);
     }
 
     if (connectionPreview) {

diff --git a/lib/features/bendpoints/ConnectionSegmentMove.js b/lib/features/bendpoints/ConnectionSegmentMove.js
@@ -267,7 +267,6 @@ export default function ConnectionSegmentMove(
 
     // add dragger gfx
     context.draggerGfx = addSegmentDragger(layer, context.segmentStart, context.segmentEnd);
-    svgClasses(context.draggerGfx).add('djs-dragging');
 
     canvas.addMarker(connection, MARKER_CONNECT_UPDATING);
   });