Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connection selection outline + context pad position #826

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Connection selection outline + context pad position #826

merged 2 commits into from
Nov 10, 2023

Conversation

smbea
Copy link
Contributor

@smbea smbea commented Nov 9, 2023

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Nov 9, 2023
@smbea smbea marked this pull request as ready for review November 9, 2023 18:43
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Nov 9, 2023
@smbea smbea requested review from a team, philippfromme and barmac and removed request for a team November 9, 2023 18:43
nikku
nikku reviewed Nov 10, 2023
View reviewed changes
assets/diagram-js.css Outdated Show resolved Hide resolved
@smbea smbea force-pushed the connection-outline branch from af76b07 to 0cfd9c7 Compare November 10, 2023 08:17
@smbea smbea force-pushed the connection-outline branch from 0cfd9c7 to 3084368 Compare November 10, 2023 08:57
@smbea smbea force-pushed the connection-outline branch from 3084368 to 8ea3bd0 Compare November 10, 2023 13:14
@nikku
Copy link
Member

nikku commented Nov 10, 2023

Works! :)

@nikku nikku merged commit 522e06f into develop Nov 10, 2023
11 checks passed
@nikku nikku deleted the connection-outline branch November 10, 2023 13:42
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku left review comments

@barmac barmac barmac approved these changes

@philippfromme philippfromme Awaiting requested review from philippfromme philippfromme was automatically assigned from bpmn-io/modeling-dev

Assignees

@smbea smbea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smbea @nikku @barmac