-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default dtype and device to SB environment #38
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 38 40 +2
Lines 1460 1484 +24
=========================================
+ Hits 1460 1484 +24 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Romain Ageron <[email protected]>
BusyBeaver-42
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💬 Pull Request Description
The
get/set/reset_env
functions have been moved to their own file namedenvironment.py
and all the dtype and device occurences in methods signatures have been made optional with a default value toNone
.✔️ Check list
🚀 New features
None
🐞 Bug fixes
None
📣 Supplementary information
The configure default values for the tensors' dtype and device, it is recommanded to ather use PyTorch's
torch.set_default_dtype
andtorch.set_default_device
functions.We considered the possibility of configuring these values via the SB environment directly, but this would risk creating a mismatch between the information stored in the environment and the actual default value, should a call be made to one of PyTorch's functions in the meantime.