Skip to content

Commit

Permalink
Fix concurrency warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
bradhowes committed Nov 23, 2024
1 parent c44132b commit a0bcc7a
Show file tree
Hide file tree
Showing 17 changed files with 79 additions and 60 deletions.
26 changes: 19 additions & 7 deletions --NAME--.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -825,6 +825,7 @@
CLANG_WARN_SUSPICIOUS_MOVE = YES;
CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
CURRENT_PROJECT_VERSION = "$(CURRENT_PROJECT_VERSION)";
DEAD_CODE_STRIPPING = YES;
DEVELOPMENT_TEAM = "$(DEVELOPMENT_TEAM)";
ENABLE_STRICT_OBJC_MSGSEND = YES;
Expand All @@ -836,8 +837,13 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 14.0;
MACOSX_DEPLOYMENT_TARGET = 11.0;
IPHONEOS_DEPLOYMENT_TARGET = "$(MIN_IOS_DEPLOYMENT_TARGET)";
MACOSX_DEPLOYMENT_TARGET = "$(MIN_MACOSX_DEPLOYMENT_TARGET)";
MARKETING_VERSION = "$(MARKETING_VERSION)";
SWIFT_STRICT_CONCURRENCY = complete;
SWIFT_UPCOMING_FEATURE_GLOBAL_CONCURRENCY = YES;
SWIFT_UPCOMING_FEATURE_REGION_BASED_ISOLATION = YES;
SWIFT_VERSION = 5.0;
VERSIONING_SYSTEM = "apple-generic";
};
name = Release;
Expand Down Expand Up @@ -1153,6 +1159,7 @@
CLANG_WARN_SUSPICIOUS_MOVE = YES;
CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
CURRENT_PROJECT_VERSION = "$(CURRENT_PROJECT_VERSION)";
DEAD_CODE_STRIPPING = YES;
DEVELOPMENT_TEAM = "$(DEVELOPMENT_TEAM)";
ENABLE_STRICT_OBJC_MSGSEND = YES;
Expand All @@ -1165,9 +1172,14 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 14.0;
MACOSX_DEPLOYMENT_TARGET = 11.0;
IPHONEOS_DEPLOYMENT_TARGET = "$(MIN_IOS_DEPLOYMENT_TARGET)";
MACOSX_DEPLOYMENT_TARGET = "$(MIN_MACOSX_DEPLOYMENT_TARGET)";
MARKETING_VERSION = "$(MARKETING_VERSION)";
ONLY_ACTIVE_ARCH = YES;
SWIFT_STRICT_CONCURRENCY = complete;
SWIFT_UPCOMING_FEATURE_GLOBAL_CONCURRENCY = YES;
SWIFT_UPCOMING_FEATURE_REGION_BASED_ISOLATION = YES;
SWIFT_VERSION = 5.0;
VERSIONING_SYSTEM = "apple-generic";
};
name = Debug;
Expand Down Expand Up @@ -1550,15 +1562,15 @@
repositoryURL = "https://github.com/bradhowes/AUv3Support";
requirement = {
kind = exactVersion;
version = 14.0.1;
version = 14.0.4;
};
};
BD8D4E1327B589D4007011A5 /* XCRemoteSwiftPackageReference "knob" */ = {
isa = XCRemoteSwiftPackageReference;
repositoryURL = "https://github.com/bradhowes/knob";
requirement = {
kind = upToNextMajorVersion;
minimumVersion = 3.0.0;
kind = exactVersion;
version = 3.0.4;
};
};
/* End XCRemoteSwiftPackageReference section */
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,17 @@
"kind" : "remoteSourceControl",
"location" : "https://github.com/bradhowes/AUv3Support",
"state" : {
"revision" : "2790d6c7b5f183f1b0dd9abcff6ae8a247e58f63",
"version" : "14.0.1"
"revision" : "c717cc2df4f1bbbf20ae4aa17bdc8e82c478af1e",
"version" : "14.0.4"
}
},
{
"identity" : "knob",
"kind" : "remoteSourceControl",
"location" : "https://github.com/bradhowes/knob",
"state" : {
"revision" : "96ef8c40bb826c961e28f658ae9b782a34287cd5",
"version" : "3.0.3"
"revision" : "16e2265e836fede2bf1a3b8df5a3b32dc26fe4fe",
"version" : "3.0.4"
}
}
],
Expand Down
6 changes: 6 additions & 0 deletions Configuration/Common.xcconfig
Original file line number Diff line number Diff line change
Expand Up @@ -52,3 +52,9 @@ AU_PRODUCT_NAME = $(AU_BASE_NAME)AU

// The bundle that holds the AUv3 component
AUDIO_COMPONENT_BUNDLE = $(HOST_PRODUCT_BUNDLE_IDENTIFIER).framework

// The minimum iOS version that we support -- affects build, but not SPM Package. Must edit there as well.
MIN_IOS_DEPLOYMENT_TARGET = 16.4

// The minimum macOS version that we support
MIN_MACOSX_DEPLOYMENT_TARGET = 14.6
2 changes: 1 addition & 1 deletion Packages/Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ let package = Package(
.library(name: "Theme", targets: ["Theme"])
],
dependencies: [
.package(url: "https://github.com/bradhowes/AUv3Support", exact: "14.0.1"),
.package(url: "https://github.com/bradhowes/AUv3Support", exact: "14.0.4"),
],
targets: [
.target(
Expand Down
6 changes: 3 additions & 3 deletions Packages/Sources/Theme/Theme.swift
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ import UIKit
public enum Theme {

public enum ColorKind: String {
case label
case knobProgress
case title
case knobLabelColor
case knobProgressColor
case backgroundTitleColor
}

public static func color(_ kind: ColorKind) -> UIColor {
Expand Down
2 changes: 1 addition & 1 deletion iOS/App/MainViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ final class MainViewController: UIViewController {
componentFlags: 0, componentFlagsMask: 0
)

let tintColor = UIColor(named: "label")!
let tintColor = UIColor.knobLabel
let config = HostViewConfig(
name: bundle.auBaseName,
appDelegate: delegate,
Expand Down
Loading

0 comments on commit a0bcc7a

Please sign in to comment.